xgboost 0.90 (new formula) #43246
xgboost 0.90 (new formula) #43246
Conversation
|
Please don't specify the amount of jobs for make. That might cause issues on other systems. |
|
My bad, updated |
|
The docs say it requires gcc to enable multi-threading - do you think that would be necessary for this Formula? |
|
Yeah, that'd be ideal. Just pushed an update. |
|
It looks like |
|
Sorry the noise. It was due to having |
Formula/xgboost.rb
Outdated
| :revision => "515f5f5c4779ff5361dcd796e22d55937e1048ea" | ||
|
|
||
| depends_on "cmake" => :build | ||
| depends_on "gcc@8" |
There was a problem hiding this comment.
Sorry to disagree with @javian there, but unless multithreading is essential to the app's behaviour, we generally avoid it. GCC is a heavy dependency, so we want to avoid it if at all possible, and compile with the system compiler.
Using libomp maybe help provide OpenMP support, if that's what you need.
And in any case, compiling with an older version of GCC is a definite “no way”.
There was a problem hiding this comment.
Hey @fxcoudert, thanks for the feedback on this as well. It sounds like @hcho3 has it working with libomp but it isn't merged yet, so will see what the maintainers want to do: dmlc/xgboost#4477
|
Hey @fxcoudert, I updated the formula to work with Apple Clang (disabled OpenMP). Also switched to |
|
@BrewTestBot test this please |
|
Thanks @ankane! Without contributions like yours it'd be impossible to keep homebrew going with the high standards that users have come to expect from the project. You can feel good knowing that you've made the world a tiny bit better for homebrew users around the world! 👍 🎉 |
|
Thanks @SMillerDev and @fxcoudert 👍 |
brew install --build-from-source <formula>, where<formula>is the name of the formula you're submitting?brew test <formula>, where<formula>is the name of the formula you're submitting?brew audit --strict <formula>(after doingbrew install <formula>)?